Re: [PATCH] perf: Add missing newline at end of file

From: Geert Uytterhoeven
Date: Sun Apr 10 2022 - 05:46:32 EST


Hi Zhengjun,

On Fri, Apr 8, 2022 at 4:45 PM Xing Zhengjun
<zhengjun.xing@xxxxxxxxxxxxxxx> wrote:
> On 4/5/2022 9:59 PM, Liang, Kan wrote:
> >> On Mon, Jun 17, 2019 at 6:00 PM Arnaldo Carvalho de Melo
> >> <arnaldo.melo@xxxxxxxxx> wrote:
> >>> Em Mon, Jun 17, 2019 at 04:47:25PM +0200, Geert Uytterhoeven escreveu:
> >>>> "git diff" says:
> >>>>
> >>>> \ No newline at end of file
> >>>>
> >>>> after modifying the files.
> >>> Auto generated files, IIRC, Andi, Kan, Sukadev?
> >> The auto-generated files have been updated, the issue still exists.
> >>
> > It seems like a converter tool issue.
> >
> > + Zhengjun
> >
> > Zhengjun, could you please take a look?
> >
> > Thanks,
> > Kan
> It only happened for perf core event files. Add "\n" at the end of the
> perf core event file, then the issue is fixed.
> I have updated the event convert tool
> https://github.com/intel/event-converter-for-linux-perf , then the next
> time uses the convert tool to generate perf events, the issue will be
> disappeared.

Thanks a lot!

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds