Re: [PATCH V3 2/7] iio: adc: sc27xx: fix read big scale voltage not right

From: Jonathan Cameron
Date: Sun Apr 10 2022 - 12:02:49 EST


On Thu, 7 Apr 2022 16:21:43 +0800
Cixi Geng <gengcixi@xxxxxxxxx> wrote:

> From: Cixi Geng <cixi.geng1@xxxxxxxxxx>
>
> Fix wrong configuration value of SC27XX_ADC_SCALE_MASK and
> SC27XX_ADC_SCALE_SHIFT by spec documetation.
>
> Signed-off-by: Cixi Geng <cixi.geng1@xxxxxxxxxx>
> Reviewed-by: Baolin Wang <baolin.wang7@xxxxxxxxx>
Fixes tag?
No need to resend for this though, just reply with the appropriate
tag so when I use b4 it'll be picked up.

Thanks,

Jonathan

> ---
> drivers/iio/adc/sc27xx_adc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iio/adc/sc27xx_adc.c b/drivers/iio/adc/sc27xx_adc.c
> index 00098caf6d9e..aee076c8e2b1 100644
> --- a/drivers/iio/adc/sc27xx_adc.c
> +++ b/drivers/iio/adc/sc27xx_adc.c
> @@ -36,8 +36,8 @@
>
> /* Bits and mask definition for SC27XX_ADC_CH_CFG register */
> #define SC27XX_ADC_CHN_ID_MASK GENMASK(4, 0)
> -#define SC27XX_ADC_SCALE_MASK GENMASK(10, 8)
> -#define SC27XX_ADC_SCALE_SHIFT 8
> +#define SC27XX_ADC_SCALE_MASK GENMASK(10, 9)
> +#define SC27XX_ADC_SCALE_SHIFT 9
>
> /* Bits definitions for SC27XX_ADC_INT_EN registers */
> #define SC27XX_ADC_IRQ_EN BIT(0)