Re: [PATCH] dmaengine: imx-sdma: fix regression with uart scripts

From: Russell King (Oracle)
Date: Mon Apr 11 2022 - 03:17:20 EST


On Mon, Apr 11, 2022 at 11:29:23AM +0530, Vinod Koul wrote:
> Hi Kevin,
>
> On 10-04-22, 18:28, Kevin Groeneveld wrote:
> > On 2022-04-08 13:39, Vinod Koul wrote:
> > > 1. Patch title should reflect the change introduced, so the title is not
> > > apt, pls revise
> >
> > In hindsight the title was not very descriptive. I will update and send a
> > v2. Maybe something like:
> >
> > dmaengine: imx-sdma: fix init of uart scripts
> >
> > > 2. Is this in response to rmk's report, if so, please add reported-by
> >
> > No. I am not even aware of any report on this issue. I discovered the issue
> > on my own and found the problem commit by doing a bisect.
>
> Okay I am adding Russell here to see if this fixes his issue as well..

I "fixed" my issue by updating my SDMA firmware to the later version,
which I think is fine provided I don't down-grade the kernel.

That said, I do support this attempt to fix NXP's cockup, so, having
looked at the patch:

Acked-by: Russell King (Oracle) <rmk+kernel@xxxxxxxxxxxxxxx>

Thanks.

--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!