Re: [PATCH v2 2/4] dmaengine: sun6i: Do not use virt_to_phys
From: kernel test robot
Date: Mon Apr 11 2022 - 04:11:03 EST
Hi Samuel,
I love your patch! Perhaps something to improve:
[auto build test WARNING on vkoul-dmaengine/next]
[also build test WARNING on sunxi/sunxi/for-next v5.18-rc2 next-20220411]
[cannot apply to mripard/sunxi/for-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/intel-lab-lkp/linux/commits/Samuel-Holland/dmaengine-sun6i-Allwinner-D1-support/20220411-124826
base: https://git.kernel.org/pub/scm/linux/kernel/git/vkoul/dmaengine.git next
config: microblaze-buildonly-randconfig-r004-20220411 (https://download.01.org/0day-ci/archive/20220411/202204111614.kGz2adbh-lkp@xxxxxxxxx/config)
compiler: microblaze-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/280420721fd264a03a3d3f9fbe2b4e6bfddd0f79
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Samuel-Holland/dmaengine-sun6i-Allwinner-D1-support/20220411-124826
git checkout 280420721fd264a03a3d3f9fbe2b4e6bfddd0f79
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=microblaze SHELL=/bin/bash drivers/dma/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>
All warnings (new ones prefixed by >>):
In file included from include/linux/device.h:15,
from include/linux/dmaengine.h:8,
from drivers/dma/sun6i-dma.c:12:
drivers/dma/sun6i-dma.c: In function 'sun6i_dma_dump_chan_regs':
>> drivers/dma/sun6i-dma.c:244:34: warning: format '%lx' expects argument of type 'long unsigned int', but argument 5 has type 'int' [-Wformat=]
244 | dev_dbg(sdev->slave.dev, "Chan %d reg: 0x%lx\n"
| ^~~~~~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:129:41: note: in definition of macro 'dev_printk'
129 | _dev_printk(level, dev, fmt, ##__VA_ARGS__); \
| ^~~
include/linux/dev_printk.h:163:45: note: in expansion of macro 'dev_fmt'
163 | dev_printk(KERN_DEBUG, dev, dev_fmt(fmt), ##__VA_ARGS__); \
| ^~~~~~~
drivers/dma/sun6i-dma.c:244:9: note: in expansion of macro 'dev_dbg'
244 | dev_dbg(sdev->slave.dev, "Chan %d reg: 0x%lx\n"
| ^~~~~~~
drivers/dma/sun6i-dma.c:244:52: note: format string is defined here
244 | dev_dbg(sdev->slave.dev, "Chan %d reg: 0x%lx\n"
| ~~^
| |
| long unsigned int
| %x
vim +244 drivers/dma/sun6i-dma.c
240
241 static inline void sun6i_dma_dump_chan_regs(struct sun6i_dma_dev *sdev,
242 struct sun6i_pchan *pchan)
243 {
> 244 dev_dbg(sdev->slave.dev, "Chan %d reg: 0x%lx\n"
245 "\t___en(%04x): \t0x%08x\n"
246 "\tpause(%04x): \t0x%08x\n"
247 "\tstart(%04x): \t0x%08x\n"
248 "\t__cfg(%04x): \t0x%08x\n"
249 "\t__src(%04x): \t0x%08x\n"
250 "\t__dst(%04x): \t0x%08x\n"
251 "\tcount(%04x): \t0x%08x\n"
252 "\t_para(%04x): \t0x%08x\n\n",
253 pchan->idx, pchan->base - sdev->base,
254 DMA_CHAN_ENABLE,
255 readl(pchan->base + DMA_CHAN_ENABLE),
256 DMA_CHAN_PAUSE,
257 readl(pchan->base + DMA_CHAN_PAUSE),
258 DMA_CHAN_LLI_ADDR,
259 readl(pchan->base + DMA_CHAN_LLI_ADDR),
260 DMA_CHAN_CUR_CFG,
261 readl(pchan->base + DMA_CHAN_CUR_CFG),
262 DMA_CHAN_CUR_SRC,
263 readl(pchan->base + DMA_CHAN_CUR_SRC),
264 DMA_CHAN_CUR_DST,
265 readl(pchan->base + DMA_CHAN_CUR_DST),
266 DMA_CHAN_CUR_CNT,
267 readl(pchan->base + DMA_CHAN_CUR_CNT),
268 DMA_CHAN_CUR_PARA,
269 readl(pchan->base + DMA_CHAN_CUR_PARA));
270 }
271
--
0-DAY CI Kernel Test Service
https://01.org/lkp