Re: [PATCHv2] drm/amdgpu: disable ASPM on Intel AlderLake based systems

[Paul Menzel]

Dear Richard,


Am 11.04.22 um 13:38 schrieb Gong, Richard:

> On 4/11/2022 2:41 AM, Paul Menzel wrote:
> > [Cc: +<Dell.Client.Kernel@xxxxxxxx>]

> > Am 11.04.22 um 02:27 schrieb Gong, Richard:
> >
> > > On 4/8/2022 7:19 PM, Paul Menzel wrote:
> >
> > > > Am 08.04.22 um 21:05 schrieb Richard Gong:
> > > > > Active State Power Management (ASPM) feature is enabled since 
> > > > > kernel 5.14.
> > > > > There are some AMD GFX cards (such as WX3200 and RX640) that cannot be
> > > > > used with Intel AlderLake based systems to enable ASPM. Using these 
> > > > > GFX
> > > >
> > > > Alder Lake
> > > will correct in the next version.
> > > > > cards as video/display output, Intel Alder Lake based systems will hang
> > > > > during suspend/resume.
> > > >
> > > > Please reflow for 75 characters per line.
> > > >
> > > > Also please mention the exact system you had problems with (also 
> > > > firmware versions).
> > > >
> > > > > Add extra check to disable ASPM on Intel AlderLake based systems.
> > > >
> > > > Is that a problem with Intel Alder Lake or the Dell system? 
> > > > Shouldn’t ASPM just be disabled for the problematic cards for the 
> > > > Dell system. You write newer cards worked fine.
> > >
> > > There is a problem with Dell system (Dell Precision DT workstation), 
> > > which is based on Intel Alder Lake.
> > >
> > > ASPM works just fine on these GPU's. It's more of an issue with 
> > > whether the underlying platform supports ASPM or not.
> >
> > At least you didn’t document what the real issue is,
>
> You can refer to bug tag from the comment messages.
>
> Link: https://gitlab.freedesktop.org/drm/amd/-/issues/1885

No, the commit message should be self-contained, and reviewers and 
readers of the commit message not required to read comments of bug 
reports. Please add the necessary information to the commit message.


Kind regards,

Paul


> > that ASPM does not work. With current information (some GPU graphics 
> > card with the the Dell system and others don’t), it could be the GPU, 
> > the Dell system (firmware, …), a problem with Alder Lake SOC, or 
> > another bug. I hope you are in contact with Dell to analyze it, so 
> > ASPM can be enabled again.
> >
> > […]
> >
> >
> > Kind regards,
> >
> > Paul