Re: [PATCH v8 02/20] cachefiles: extract write routine

From: JeffleXu
Date: Mon Apr 11 2022 - 08:30:45 EST




On 4/11/22 8:13 PM, David Howells wrote:
> Jeffle Xu <jefflexu@xxxxxxxxxxxxxxxxx> wrote:
>
>> It is worth nothing that, ki->inval_counter is not initialized after
>> this cleanup.
>
> I think you meant "It is worth noting that, ...".

Yeah...

>
> Btw, is there a particular reason that you didn't want to pass in a pointer to
> a netfs_cache_resources struct?

IMHO, "struct netfs_cache_resources" is more like an interface for
netfs, while here __cachefiles_prepare_write() and __cachefiles_write()
are called inside Cachefiles module.

--
Thanks,
Jeffle