Re: [PATCH v8 05/20] cachefiles: implement on-demand read

[JeffleXu]

On 4/11/22 8:44 PM, David Howells wrote:
> Jeffle Xu <jefflexu@xxxxxxxxxxxxxxxxx> wrote:
> 
>>  	/*
>>  	 * Uninstall anon_fd to the cachefiles object, so that no further
>>  	 * associated requests will get enqueued.
>>  	 */
> 
> "Uninstall anon_fd from..."?

Okay, will be fixed.

> 
>> +static int init_read_req(struct cachefiles_req *req, void *private)
> 
> Prefix with "cachefiles_" please (or "cachefiles_ondemand_").

Alright.

Thanks for reviewing.

-- 
Thanks,
Jeffle