Re: [PATCH 2/4] mm/migration: remove unneeded lock page and PageMovable check

From: Christoph Hellwig
Date: Mon Apr 11 2022 - 10:10:35 EST


On Sat, Apr 09, 2022 at 03:38:44PM +0800, Miaohe Lin wrote:
> When non-lru movable page was freed from under us, __ClearPageMovable must
> have been done. Even if it's not done, ClearPageIsolated here won't hurt
> as page will be freed anyway. So we can thus remove unneeded lock page and
> PageMovable check here.
>
> Signed-off-by: Miaohe Lin <linmiaohe@xxxxxxxxxx>

Looks good:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>