Re: [PATCH] security: do not leak information in ioctl

From: Tom Rix
Date: Mon Apr 11 2022 - 12:31:34 EST



On 4/11/22 8:07 AM, Christoph Hellwig wrote:
Wrong subject prefix, and this really should be split into one patch for
pcd and one for sr.
ok i will split
The sr prt looks sensible to me. But for pcd why can't you just
initialize buffer using

char buffer[32] = { };

and be done with it?

The failure can happen in the transfer loop, so some of the data will not be zero.

And checking status should be done.

zero-ing is because i am paranoid.

Tom