Re: [PATCH v11] arm64: dts: qcom: sc7280: Add WPSS remoteproc node

[Manikanta Pubbisetty]

On 4/7/2022 11:46 PM, Stephen Boyd wrote:
> Quoting Manikanta Pubbisetty (2022-04-06 23:11:50)
> > On 4/6/2022 8:47 PM, Stephen Boyd wrote:
> > > Quoting Manikanta Pubbisetty (2022-04-06 04:11:01)
> > > > diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
> > > > index ecbf2b89d896..f61a3e15fa8b 100644
> > > > --- a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
> > > > +++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
> > > > @@ -547,3 +547,6 @@ sw_ctrl: sw-ctrl {
> > > >           };
> > > >    };
> > > >
> > > > +&remoteproc_wpss {
> > > > +       status = "okay";
> > > > +};
> > >
> > > This should be before the PINCTRL section in this file. I believe after
> > > the uart node.
> >
> > I have not understood your concern, any specific reason as why
> > remoteproc_wpss node has to be before PINCTRL section?
> > There is no problem in moving, just wanted to understand the reason.
>
> It's a style that this file is following. The end of the file is for
> pinctrl configurations. Before that section is where soc nodes are
> modified. There are different sections of the file with comments
> delineating them.
>
> Furthermore, adding things to the end of the file is a recipe for
> conflicts when applying patches as a maintainer. This is another reason
> why we sort the nodes. I suspect having different sections helps here so
> that we don't sort everything alphabetically and have pinctrl settings
> scattered throughout the file.

Thanks for the explanation, I'll send out a revised patch.

Manikanta