Re: [PATCH] memory: renesas-rpc-if: Simplify single/double data register access
From: Geert Uytterhoeven
Date: Tue Apr 12 2022 - 07:17:40 EST
Hi Wolfram,
On Tue, Apr 12, 2022 at 11:49 AM Wolfram Sang
<wsa+renesas@xxxxxxxxxxxxxxxxxxxx> wrote:
> > > > + regmap_write(rpc->regmap, RPCIF_SMWDR0, *p++);
> > >
> > > Last '++' can be omitted?
> >
> > I know. But I think it looks nicer this way ;-)
>
> I have to admit it looks a little like "I copy&pasted without thinking"
> to me :)
But that's not what happened. I even compared the assembler output of
various solutions.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds