[jpirko-mlxsw:jiri_devel_linecards 79/93] drivers/net/netdevsim/dev.c:638:14: error: too many arguments to function call, expected 3, have 4

From: kernel test robot
Date: Tue Apr 12 2022 - 07:58:52 EST


tree: https://github.com/jpirko/linux_mlxsw jiri_devel_linecards
head: e31049bc6a06f24c077e61e74b1bf1f137572726
commit: 5cfe0dc86bde79b21b5e0097a45355e3a5dbb1cb [79/93] netdevsim: allow port objects to be linked with line cards
config: hexagon-allyesconfig (https://download.01.org/0day-ci/archive/20220412/202204121850.XJ5zRujX-lkp@xxxxxxxxx/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project fe2478d44e4f7f191c43fef629ac7a23d0251e72)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/jpirko/linux_mlxsw/commit/5cfe0dc86bde79b21b5e0097a45355e3a5dbb1cb
git remote add jpirko-mlxsw https://github.com/jpirko/linux_mlxsw
git fetch --no-tags jpirko-mlxsw jiri_devel_linecards
git checkout 5cfe0dc86bde79b21b5e0097a45355e3a5dbb1cb
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>):

>> drivers/net/netdevsim/dev.c:638:14: error: too many arguments to function call, expected 3, have 4
NULL, i);
^
drivers/net/netdevsim/dev.c:612:1: note: '__nsim_dev_port_add' declared here
__nsim_dev_port_add(struct nsim_dev *nsim_dev, enum nsim_dev_port_type type,
^
>> drivers/net/netdevsim/dev.c:651:39: error: too many arguments to function call, expected single argument 'nsim_dev_port', have 3 arguments
__nsim_dev_port_del(nsim_dev_port, NULL, i);
~~~~~~~~~~~~~~~~~~~ ^~~~~~~
include/linux/stddef.h:8:14: note: expanded from macro 'NULL'
#define NULL ((void *)0)
^
drivers/net/netdevsim/dev.c:614:13: note: '__nsim_dev_port_del' declared here
static void __nsim_dev_port_del(struct nsim_dev_port *nsim_dev_port);
^
>> drivers/net/netdevsim/dev.c:1393:12: error: conflicting types for '__nsim_dev_port_add'
static int __nsim_dev_port_add(struct nsim_dev *nsim_dev, enum nsim_dev_port_type type,
^
drivers/net/netdevsim/dev.c:612:1: note: previous declaration is here
__nsim_dev_port_add(struct nsim_dev *nsim_dev, enum nsim_dev_port_type type,
^
drivers/net/netdevsim/dev.c:1503:14: error: too many arguments to function call, expected 3, have 4
NULL, i);
^
drivers/net/netdevsim/dev.c:612:1: note: '__nsim_dev_port_add' declared here
__nsim_dev_port_add(struct nsim_dev *nsim_dev, enum nsim_dev_port_type type,
^
drivers/net/netdevsim/dev.c:1839:27: error: too many arguments to function call, expected 3, have 4
nsim_dev_linecard, port_index);
^~~~~~~~~~
drivers/net/netdevsim/dev.c:612:1: note: '__nsim_dev_port_add' declared here
__nsim_dev_port_add(struct nsim_dev *nsim_dev, enum nsim_dev_port_type type,
^
5 errors generated.


vim +638 drivers/net/netdevsim/dev.c

629
630 static int nsim_esw_switchdev_enable(struct nsim_dev *nsim_dev,
631 struct netlink_ext_ack *extack)
632 {
633 struct nsim_dev_port *nsim_dev_port, *tmp;
634 int i, err;
635
636 for (i = 0; i < nsim_dev_get_vfs(nsim_dev); i++) {
637 err = __nsim_dev_port_add(nsim_dev, NSIM_DEV_PORT_TYPE_VF,
> 638 NULL, i);
639 if (err) {
640 NL_SET_ERR_MSG_MOD(extack, "Failed to initialize VFs' netdevsim ports");
641 pr_err("Failed to initialize VF id=%d. %d.\n", i, err);
642 goto err_port_add_vfs;
643 }
644 }
645 nsim_dev->esw_mode = DEVLINK_ESWITCH_MODE_SWITCHDEV;
646 return 0;
647
648 err_port_add_vfs:
649 list_for_each_entry_safe(nsim_dev_port, tmp, &nsim_dev->port_list, list)
650 if (nsim_dev_port_is_vf(nsim_dev_port))
> 651 __nsim_dev_port_del(nsim_dev_port, NULL, i);
652 return err;
653 }
654

--
0-DAY CI Kernel Test Service
https://01.org/lkp