Re: [PATCH] ipc/sem: Remove redundant assignments

From: Michal Orzel
Date: Tue Apr 12 2022 - 11:19:48 EST


Hi Nathan,

On 11.04.2022 17:47, Nathan Chancellor wrote:
> Hi Michal,
>
> On Sat, Apr 09, 2022 at 12:19:31PM +0200, Michal Orzel wrote:
>> Get rid of redundant assignments which end up in values not being
>> read either because they are overwritten or the function ends.
>>
>> Reported by clang-tidy [deadcode.DeadStores]
>>
>> Signed-off-by: Michal Orzel <michalorzel.eng@xxxxxxxxx>
>
> Thank you for the patch! This should go through Andrew Morton, now CC'd.
>
> For the future, having some history behind the origin of these warnings
> would make review a little easier. I'll comment on each below.
>
> Reviewed-by: Nathan Chancellor <nathan@xxxxxxxxxx>
>
Thanks,
I will keep that in mind when sending other patches fixing static analyzer findings.

Cheers,
Michal