Re: [PATCH v2 0/4] Tidy up symbol end fixup

From: Ian Rogers
Date: Tue Apr 12 2022 - 12:21:12 EST


On Tue, Apr 12, 2022 at 8:48 AM Ian Rogers <irogers@xxxxxxxxxx> wrote:
>
> Fixing up more symbol ends as introduced in:
> https://lore.kernel.org/lkml/20220317135536.805-1-mpetlan@xxxxxxxxxx/
> caused perf annotate to run into memory limits - every symbol holds
> all the disassembled code in the annotation, and so making symbols
> ends further away dramatically increased memory usage (40MB to
> >1GB). Modify the symbol end logic so that special kernel cases aren't
> applied in the common case.
>
> v2. Drops a merged patch. Fixes a build issue with libbfd enabled.
>
> Ian Rogers (4):
> perf symbols: Always do architecture specific fixups
> perf symbols: Add is_kernel argument to fixup end
> perf symbol: By default only fix zero length symbols
> perf symbols: More specific architecture end fixing
>
> tools/perf/arch/arm64/util/machine.c | 14 +++++++++-----
> tools/perf/arch/powerpc/util/machine.c | 10 +++++++---
> tools/perf/arch/s390/util/machine.c | 12 ++++++++----
> tools/perf/util/symbol-elf.c | 2 +-
> tools/perf/util/symbol.c | 16 +++++++++-------
> tools/perf/util/symbol.h | 4 ++--
> 6 files changed, 36 insertions(+), 22 deletions(-)

Missed the:

Signed-off-by: Ian Rogers <irogers@xxxxxxxxxx>

Thanks,
Ian

> --
> 2.35.1.1178.g4f1659d476-goog
>