[djwong-xfs:vectorized-scrub 99/396] fs/xfs/scrub/repair.c:181:1: warning: no previous prototype for 'xrep_defer_finish'
From: kernel test robot
Date: Tue Apr 12 2022 - 21:31:30 EST
tree: https://git.kernel.org/pub/scm/linux/kernel/git/djwong/xfs-linux.git vectorized-scrub
head: bd756ef7af68274b79308166ee64949d288be861
commit: 80bc1e058e807de278cc530a53694879e4f70cb3 [99/396] xfs: implement block reservation accounting for btrees we're staging
config: s390-buildonly-randconfig-r001-20220411 (https://download.01.org/0day-ci/archive/20220413/202204130954.KyCjtAyn-lkp@xxxxxxxxx/config)
compiler: s390-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/djwong/xfs-linux.git/commit/?id=80bc1e058e807de278cc530a53694879e4f70cb3
git remote add djwong-xfs https://git.kernel.org/pub/scm/linux/kernel/git/djwong/xfs-linux.git
git fetch --no-tags djwong-xfs vectorized-scrub
git checkout 80bc1e058e807de278cc530a53694879e4f70cb3
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=s390 SHELL=/bin/bash fs/xfs/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>
All warnings (new ones prefixed by >>):
>> fs/xfs/scrub/repair.c:181:1: warning: no previous prototype for 'xrep_defer_finish' [-Wmissing-prototypes]
181 | xrep_defer_finish(
| ^~~~~~~~~~~~~~~~~
vim +/xrep_defer_finish +181 fs/xfs/scrub/repair.c
178
179 /* Finish all deferred work attached to the repair transaction. */
180 int
> 181 xrep_defer_finish(
182 struct xfs_scrub *sc)
183 {
184 int error;
185
186 /* Keep the AG header buffers locked so we can keep going. */
187 if (sc->sa.agi_bp) {
188 xfs_ialloc_log_agi(sc->tp, sc->sa.agi_bp, XFS_AGI_MAGICNUM);
189 xfs_trans_bhold(sc->tp, sc->sa.agi_bp);
190 }
191
192 if (sc->sa.agf_bp) {
193 xfs_alloc_log_agf(sc->tp, sc->sa.agf_bp, XFS_AGF_MAGICNUM);
194 xfs_trans_bhold(sc->tp, sc->sa.agf_bp);
195 }
196
197 error = xfs_defer_finish(&sc->tp);
198 if (error)
199 return error;
200
201 /*
202 * The buffer log item (and hence the blf type) can detach from
203 * the buffer across the transaction rolls, so ensure that the
204 * types are still set on the AG header buffers. Release the hold
205 * that we set above because defer_finish won't do that for us.
206 */
207 if (sc->sa.agi_bp) {
208 xfs_trans_bhold_release(sc->tp, sc->sa.agi_bp);
209 xfs_trans_buf_set_type(sc->tp, sc->sa.agi_bp, XFS_BLFT_AGI_BUF);
210 }
211 if (sc->sa.agf_bp) {
212 xfs_trans_bhold_release(sc->tp, sc->sa.agf_bp);
213 xfs_trans_buf_set_type(sc->tp, sc->sa.agf_bp, XFS_BLFT_AGF_BUF);
214 }
215 return 0;
216 }
217
--
0-DAY CI Kernel Test Service
https://01.org/lkp