[jsarha:topic/cros-sof-v4.14 835/9354] drivers/gpu/drm/i915/intel_display.c:5249:24: error: variable 'conn' set but not used

From: kernel test robot
Date: Tue Apr 12 2022 - 23:34:44 EST

Next message: Veerasenareddy Burru: "[net-next PATCH v5 2/7] octeon_ep: add hardware configuration APIs"
Previous message: Stephen Boyd: "[PATCH 0/2] Input: cros-ec-keyb: Don't register keyboard if doesn't exist"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Hi Maarten,

FYI, the error/warning still remains.

tree: https://github.com/jsarha/linux topic/cros-sof-v4.14
head: 6f750b16c322c9191168a3a97c427c90581d9144
commit: 17de7cbd45ef192faed9f7f17ddc8fe9155645b4 [835/9354] UPSTREAM: drm/atomic: Make atomic iterators less surprising
config: i386-randconfig-a011-20220411 (https://download.01.org/0day-ci/archive/20220413/202204131116.AR9J6kE7-lkp@xxxxxxxxx/config)
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
reproduce (this is a W=1 build):
# https://github.com/jsarha/linux/commit/17de7cbd45ef192faed9f7f17ddc8fe9155645b4
git remote add jsarha https://github.com/jsarha/linux
git fetch --no-tags jsarha topic/cros-sof-v4.14
git checkout 17de7cbd45ef192faed9f7f17ddc8fe9155645b4
# save the config file to linux build tree
mkdir build_dir
make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/gpu/drm/i915/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>):

drivers/gpu/drm/i915/intel_display.c: In function '__intel_display_resume':
drivers/gpu/drm/i915/intel_display.c:3656:19: error: variable 'crtc' set but not used [-Werror=unused-but-set-variable]
struct drm_crtc *crtc;
^~~~
drivers/gpu/drm/i915/intel_display.c: In function 'intel_encoders_pre_pll_enable':
>> drivers/gpu/drm/i915/intel_display.c:5249:24: error: variable 'conn' set but not used [-Werror=unused-but-set-variable]
struct drm_connector *conn;
^~~~
drivers/gpu/drm/i915/intel_display.c: In function 'intel_encoders_pre_enable':
drivers/gpu/drm/i915/intel_display.c:5269:24: error: variable 'conn' set but not used [-Werror=unused-but-set-variable]
struct drm_connector *conn;
^~~~
drivers/gpu/drm/i915/intel_display.c: In function 'intel_encoders_enable':
drivers/gpu/drm/i915/intel_display.c:5289:24: error: variable 'conn' set but not used [-Werror=unused-but-set-variable]
struct drm_connector *conn;
^~~~
drivers/gpu/drm/i915/intel_display.c: In function 'intel_encoders_disable':
drivers/gpu/drm/i915/intel_display.c:5309:24: error: variable 'conn' set but not used [-Werror=unused-but-set-variable]
struct drm_connector *conn;
^~~~
drivers/gpu/drm/i915/intel_display.c: In function 'intel_encoders_post_disable':
drivers/gpu/drm/i915/intel_display.c:5329:24: error: variable 'conn' set but not used [-Werror=unused-but-set-variable]
struct drm_connector *conn;
^~~~
drivers/gpu/drm/i915/intel_display.c: In function 'intel_encoders_post_pll_disable':
drivers/gpu/drm/i915/intel_display.c:5349:24: error: variable 'conn' set but not used [-Werror=unused-but-set-variable]
struct drm_connector *conn;
^~~~
drivers/gpu/drm/i915/intel_display.c: In function 'chv_prepare_pll':
drivers/gpu/drm/i915/intel_display.c:6776:13: error: variable 'bestm1' set but not used [-Werror=unused-but-set-variable]
u32 bestn, bestm1, bestm2, bestp1, bestp2, bestm2_frac;
^~~~~~
drivers/gpu/drm/i915/intel_display.c:6776:6: error: variable 'bestn' set but not used [-Werror=unused-but-set-variable]
u32 bestn, bestm1, bestm2, bestp1, bestp2, bestm2_frac;
^~~~~
drivers/gpu/drm/i915/intel_display.c: In function 'i9xx_get_initial_plane_config':
drivers/gpu/drm/i915/intel_display.c:7500:17: error: variable 'offset' set but not used [-Werror=unused-but-set-variable]
u32 val, base, offset;
^~~~~~
drivers/gpu/drm/i915/intel_display.c: In function 'skylake_get_initial_plane_config':
drivers/gpu/drm/i915/intel_display.c:8526:17: error: variable 'offset' set but not used [-Werror=unused-but-set-variable]
u32 val, base, offset, stride_mult, tiling;
^~~~~~
drivers/gpu/drm/i915/intel_display.c: In function 'ironlake_get_initial_plane_config':
drivers/gpu/drm/i915/intel_display.c:8638:17: error: variable 'offset' set but not used [-Werror=unused-but-set-variable]
u32 val, base, offset;
^~~~~~
drivers/gpu/drm/i915/intel_display.c: In function 'check_single_encoder_cloning':
>> drivers/gpu/drm/i915/intel_display.c:10472:24: error: variable 'connector' set but not used [-Werror=unused-but-set-variable]
struct drm_connector *connector;
^~~~~~~~~
drivers/gpu/drm/i915/intel_display.c: In function 'intel_modeset_pipe_config':
drivers/gpu/drm/i915/intel_display.c:10892:24: error: variable 'connector' set but not used [-Werror=unused-but-set-variable]
struct drm_connector *connector;
^~~~~~~~~
drivers/gpu/drm/i915/intel_display.c: In function 'verify_encoder_state':
drivers/gpu/drm/i915/intel_display.c:11520:24: error: variable 'connector' set but not used [-Werror=unused-but-set-variable]
struct drm_connector *connector;
^~~~~~~~~
drivers/gpu/drm/i915/intel_display.c: In function 'sanitize_watermarks':
drivers/gpu/drm/i915/intel_display.c:14419:19: error: variable 'crtc' set but not used [-Werror=unused-but-set-variable]
struct drm_crtc *crtc;
^~~~
In file included from include/uapi/linux/stddef.h:2:0,
from include/linux/stddef.h:5,
from include/uapi/linux/posix_types.h:5,
from include/uapi/linux/types.h:14,
from include/linux/types.h:6,
from include/linux/list.h:5,
from include/linux/dmi.h:5,
from drivers/gpu/drm/i915/intel_display.c:27:
drivers/gpu/drm/i915/intel_drv.h: In function 'enc_to_dig_port':
include/linux/compiler.h:176:22: error: this statement may fall through [-Werror=implicit-fallthrough=]
# define unlikely(x) __builtin_expect(!!(x), 0)
^~~~~~~~~~~~~~~~~~~~~~~~~~
include/asm-generic/bug.h:120:2: note: in expansion of macro 'unlikely'
unlikely(__ret_warn_on); \
^~~~~~~~
drivers/gpu/drm/i915/i915_utils.h:37:20: note: in expansion of macro 'WARN'
#define WARN_ON(x) WARN((x), "%s", "WARN_ON(" __stringify(x) ")")
^~~~
drivers/gpu/drm/i915/intel_drv.h:1151:3: note: in expansion of macro 'WARN_ON'
WARN_ON(!HAS_DDI(to_i915(encoder->dev)));
^~~~~~~
In file included from drivers/gpu/drm/i915/intel_display.c:36:0:
drivers/gpu/drm/i915/intel_drv.h:1152:2: note: here
case INTEL_OUTPUT_DP:
^~~~
In file included from include/uapi/linux/stddef.h:2:0,
from include/linux/stddef.h:5,
from include/uapi/linux/posix_types.h:5,
from include/uapi/linux/types.h:14,
from include/linux/types.h:6,
from include/linux/list.h:5,
from include/linux/dmi.h:5,
from drivers/gpu/drm/i915/intel_display.c:27:
drivers/gpu/drm/i915/intel_display.c: In function 'hsw_get_transcoder_state':
include/linux/compiler.h:176:22: error: this statement may fall through [-Werror=implicit-fallthrough=]
# define unlikely(x) __builtin_expect(!!(x), 0)
^~~~~~~~~~~~~~~~~~~~~~~~~~
include/asm-generic/bug.h:120:2: note: in expansion of macro 'unlikely'
unlikely(__ret_warn_on); \
^~~~~~~~
drivers/gpu/drm/i915/intel_display.c:9150:4: note: in expansion of macro 'WARN'
WARN(1, "unknown pipe linked to edp transcoder\n");
^~~~
drivers/gpu/drm/i915/intel_display.c:9151:3: note: here
case TRANS_DDI_EDP_INPUT_A_ONOFF:
^~~~
drivers/gpu/drm/i915/intel_display.c: In function 'check_digital_port_conflicts':
drivers/gpu/drm/i915/intel_display.c:10818:7: error: this statement may fall through [-Werror=implicit-fallthrough=]
if (WARN_ON(!HAS_DDI(to_i915(dev))))
^
drivers/gpu/drm/i915/intel_display.c:10820:3: note: here
case INTEL_OUTPUT_DP:
^~~~
cc1: all warnings being treated as errors
--
drivers/gpu/drm/i915/intel_ddi.c: In function 'intel_ddi_get_crtc_new_encoder':
>> drivers/gpu/drm/i915/intel_ddi.c:988:24: error: variable 'connector' set but not used [-Werror=unused-but-set-variable]
struct drm_connector *connector;
^~~~~~~~~
In file included from include/uapi/linux/stddef.h:2:0,
from include/linux/stddef.h:5,
from include/uapi/linux/posix_types.h:5,
from include/uapi/linux/types.h:14,
from include/linux/types.h:6,
from include/uapi/drm/drm.h:41,
from include/uapi/drm/i915_drm.h:30,
from drivers/gpu/drm/i915/i915_drv.h:33,
from drivers/gpu/drm/i915/intel_ddi.c:28:
drivers/gpu/drm/i915/intel_drv.h: In function 'enc_to_dig_port':
include/linux/compiler.h:176:22: error: this statement may fall through [-Werror=implicit-fallthrough=]
# define unlikely(x) __builtin_expect(!!(x), 0)
^~~~~~~~~~~~~~~~~~~~~~~~~~
include/asm-generic/bug.h:120:2: note: in expansion of macro 'unlikely'
unlikely(__ret_warn_on); \
^~~~~~~~
drivers/gpu/drm/i915/i915_utils.h:37:20: note: in expansion of macro 'WARN'
#define WARN_ON(x) WARN((x), "%s", "WARN_ON(" __stringify(x) ")")
^~~~
drivers/gpu/drm/i915/intel_drv.h:1151:3: note: in expansion of macro 'WARN_ON'
WARN_ON(!HAS_DDI(to_i915(encoder->dev)));
^~~~~~~
In file included from drivers/gpu/drm/i915/i915_trace.h:11:0,
from drivers/gpu/drm/i915/i915_drv.h:3130,
from drivers/gpu/drm/i915/intel_ddi.c:28:
drivers/gpu/drm/i915/intel_drv.h:1152:2: note: here
case INTEL_OUTPUT_DP:
^~~~
cc1: all warnings being treated as errors

vim +/conn +5249 drivers/gpu/drm/i915/intel_display.c

a5c4d7bc187bd13 Ville Syrjälä 2014-03-07 5243
fb1c98b181ae139 Maarten Lankhorst 2016-08-09 5244 static void intel_encoders_pre_pll_enable(struct drm_crtc *crtc,
fd6bbda9c7a46be Maarten Lankhorst 2016-08-09 5245 struct intel_crtc_state *crtc_state,
fb1c98b181ae139 Maarten Lankhorst 2016-08-09 5246 struct drm_atomic_state *old_state)
fb1c98b181ae139 Maarten Lankhorst 2016-08-09 5247 {
aa5e9b47b90156f Maarten Lankhorst 2017-03-09 5248 struct drm_connector_state *conn_state;
fb1c98b181ae139 Maarten Lankhorst 2016-08-09 @5249 struct drm_connector *conn;
fb1c98b181ae139 Maarten Lankhorst 2016-08-09 5250 int i;
fb1c98b181ae139 Maarten Lankhorst 2016-08-09 5251
aa5e9b47b90156f Maarten Lankhorst 2017-03-09 5252 for_each_new_connector_in_state(old_state, conn, conn_state, i) {
fb1c98b181ae139 Maarten Lankhorst 2016-08-09 5253 struct intel_encoder *encoder =
fb1c98b181ae139 Maarten Lankhorst 2016-08-09 5254 to_intel_encoder(conn_state->best_encoder);
fb1c98b181ae139 Maarten Lankhorst 2016-08-09 5255
fb1c98b181ae139 Maarten Lankhorst 2016-08-09 5256 if (conn_state->crtc != crtc)
fb1c98b181ae139 Maarten Lankhorst 2016-08-09 5257 continue;
fb1c98b181ae139 Maarten Lankhorst 2016-08-09 5258
fb1c98b181ae139 Maarten Lankhorst 2016-08-09 5259 if (encoder->pre_pll_enable)
fd6bbda9c7a46be Maarten Lankhorst 2016-08-09 5260 encoder->pre_pll_enable(encoder, crtc_state, conn_state);
fb1c98b181ae139 Maarten Lankhorst 2016-08-09 5261 }
fb1c98b181ae139 Maarten Lankhorst 2016-08-09 5262 }
fb1c98b181ae139 Maarten Lankhorst 2016-08-09 5263

:::::: The code at line 5249 was first introduced by commit
:::::: fb1c98b181ae139412eca6b7ef727b655b6125da drm/i915: Walk over encoders in crtc enable/disable using atomic state.

:::::: TO: Maarten Lankhorst <maarten.lankhorst@xxxxxxxxxxxxxxx>
:::::: CC: Maarten Lankhorst <maarten.lankhorst@xxxxxxxxxxxxxxx>

--
0-DAY CI Kernel Test Service
https://01.org/lkp

Next message: Veerasenareddy Burru: "[net-next PATCH v5 2/7] octeon_ep: add hardware configuration APIs"
Previous message: Stephen Boyd: "[PATCH 0/2] Input: cros-ec-keyb: Don't register keyboard if doesn't exist"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]