Re: [PATCH v3 2/2] staging: greybus: remove empty callback function

From: Dan Carpenter
Date: Wed Apr 13 2022 - 01:45:55 EST


On Wed, Apr 13, 2022 at 12:38:52AM -0400, Jaehee Park wrote:
> Remove the optional remove callback for the soc_codec_dev_gbaudio
> structure. The only place it is referenced is
> snd_soc_component_remove() which is only called if the sound_component
> pointer is non-null. The null function pointers here can be optionally
> ommitted. When a sound component is registered this way, the remove
> callback is optional. We can safely remove the whole gbcodec_remove
> function, which used to be an empty function with a void return type.
>
> Suggested-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> Signed-off-by: Jaehee Park <jhpark1013@xxxxxxxxx>

Thanks!

regards,
dan carpenter