[jpirko-mlxsw:jiri_devel_linecards 92/94] drivers/net/netdevsim/dev.c:119:25: error: too few arguments to function call, expected 5, have 4
From: kernel test robot
Date: Wed Apr 13 2022 - 02:05:49 EST
tree: https://github.com/jpirko/linux_mlxsw jiri_devel_linecards
head: ca9bd759ed5f4422d41446de7c31c6a189ac87df
commit: f39238e4c9d54b5f8d9ebe9c333b83509a644803 [92/94] TMP: devlink device type
config: x86_64-randconfig-a001-20220411 (https://download.01.org/0day-ci/archive/20220413/202204131305.23NkbTFh-lkp@xxxxxxxxx/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project fe2478d44e4f7f191c43fef629ac7a23d0251e72)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/jpirko/linux_mlxsw/commit/f39238e4c9d54b5f8d9ebe9c333b83509a644803
git remote add jpirko-mlxsw https://github.com/jpirko/linux_mlxsw
git fetch --no-tags jpirko-mlxsw jiri_devel_linecards
git checkout f39238e4c9d54b5f8d9ebe9c333b83509a644803
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/net/netdevsim/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>
All errors (new ones prefixed by >>):
>> drivers/net/netdevsim/dev.c:119:25: error: too few arguments to function call, expected 5, have 4
nsim_dev_linecard);
^
include/net/devlink.h:1607:1: note: 'devlink_linecard_device_create' declared here
devlink_linecard_device_create(struct devlink_linecard *linecard,
^
drivers/net/netdevsim/dev.c:870:14: error: too many arguments to function call, expected 3, have 4
NULL, i);
^
drivers/net/netdevsim/dev.c:844:1: note: '__nsim_dev_port_add' declared here
__nsim_dev_port_add(struct nsim_dev *nsim_dev, enum nsim_dev_port_type type,
^
drivers/net/netdevsim/dev.c:883:39: error: too many arguments to function call, expected single argument 'nsim_dev_port', have 3 arguments
__nsim_dev_port_del(nsim_dev_port, NULL, i);
~~~~~~~~~~~~~~~~~~~ ^~~~~~~
include/linux/stddef.h:8:14: note: expanded from macro 'NULL'
#define NULL ((void *)0)
^
drivers/net/netdevsim/dev.c:846:13: note: '__nsim_dev_port_del' declared here
static void __nsim_dev_port_del(struct nsim_dev_port *nsim_dev_port);
^
drivers/net/netdevsim/dev.c:1625:12: error: conflicting types for '__nsim_dev_port_add'
static int __nsim_dev_port_add(struct nsim_dev *nsim_dev, enum nsim_dev_port_type type,
^
drivers/net/netdevsim/dev.c:844:1: note: previous declaration is here
__nsim_dev_port_add(struct nsim_dev *nsim_dev, enum nsim_dev_port_type type,
^
drivers/net/netdevsim/dev.c:1738:14: error: too many arguments to function call, expected 3, have 4
NULL, i);
^
drivers/net/netdevsim/dev.c:844:1: note: '__nsim_dev_port_add' declared here
__nsim_dev_port_add(struct nsim_dev *nsim_dev, enum nsim_dev_port_type type,
^
drivers/net/netdevsim/dev.c:2213:27: error: too many arguments to function call, expected 3, have 4
nsim_dev_linecard, port_index);
^~~~~~~~~~
drivers/net/netdevsim/dev.c:844:1: note: '__nsim_dev_port_add' declared here
__nsim_dev_port_add(struct nsim_dev *nsim_dev, enum nsim_dev_port_type type,
^
6 errors generated.
vim +119 drivers/net/netdevsim/dev.c
f516d881f25d5ec Jiri Pirko 2021-05-05 100
f516d881f25d5ec Jiri Pirko 2021-05-05 101 static int
f516d881f25d5ec Jiri Pirko 2021-05-05 102 nsim_dev_linecard_devices_create(struct nsim_dev_linecard *nsim_dev_linecard)
f516d881f25d5ec Jiri Pirko 2021-05-05 103 {
f516d881f25d5ec Jiri Pirko 2021-05-05 104 struct devlink_linecard_device *device;
f516d881f25d5ec Jiri Pirko 2021-05-05 105 char *component_name;
f516d881f25d5ec Jiri Pirko 2021-05-05 106 int err;
f516d881f25d5ec Jiri Pirko 2021-05-05 107 int i;
f516d881f25d5ec Jiri Pirko 2021-05-05 108
f516d881f25d5ec Jiri Pirko 2021-05-05 109 snprintf(nsim_dev_linecard->device_component_name,
f516d881f25d5ec Jiri Pirko 2021-05-05 110 sizeof(nsim_dev_linecard->device_component_name), "lc%u_dev0",
f516d881f25d5ec Jiri Pirko 2021-05-05 111 nsim_dev_linecard->linecard_index);
f516d881f25d5ec Jiri Pirko 2021-05-05 112 component_name = nsim_dev_linecard->device_component_name;
f516d881f25d5ec Jiri Pirko 2021-05-05 113
f516d881f25d5ec Jiri Pirko 2021-05-05 114 for (i = 0; i < NSIM_DEV_LINECARD_DEVICE_COUNT; i++) {
f516d881f25d5ec Jiri Pirko 2021-05-05 115 if (i > 0)
f516d881f25d5ec Jiri Pirko 2021-05-05 116 component_name = NULL;
f516d881f25d5ec Jiri Pirko 2021-05-05 117 device = devlink_linecard_device_create(nsim_dev_linecard->devlink_linecard,
f516d881f25d5ec Jiri Pirko 2021-05-05 118 i, component_name,
f516d881f25d5ec Jiri Pirko 2021-05-05 @119 nsim_dev_linecard);
f516d881f25d5ec Jiri Pirko 2021-05-05 120 if (IS_ERR(device)) {
f516d881f25d5ec Jiri Pirko 2021-05-05 121 err = PTR_ERR(device);
f516d881f25d5ec Jiri Pirko 2021-05-05 122 goto rollback;
f516d881f25d5ec Jiri Pirko 2021-05-05 123 }
f516d881f25d5ec Jiri Pirko 2021-05-05 124 nsim_dev_linecard->devlink_device[i] = device;
f516d881f25d5ec Jiri Pirko 2021-05-05 125 }
f516d881f25d5ec Jiri Pirko 2021-05-05 126 return 0;
f516d881f25d5ec Jiri Pirko 2021-05-05 127
f516d881f25d5ec Jiri Pirko 2021-05-05 128 rollback:
f516d881f25d5ec Jiri Pirko 2021-05-05 129 for (i--; i >= 0; i--) {
f516d881f25d5ec Jiri Pirko 2021-05-05 130 device = nsim_dev_linecard->devlink_device[i];
f516d881f25d5ec Jiri Pirko 2021-05-05 131 devlink_linecard_device_destroy(nsim_dev_linecard->devlink_linecard,
f516d881f25d5ec Jiri Pirko 2021-05-05 132 device);
f516d881f25d5ec Jiri Pirko 2021-05-05 133 }
f516d881f25d5ec Jiri Pirko 2021-05-05 134 return err;
f516d881f25d5ec Jiri Pirko 2021-05-05 135 }
f516d881f25d5ec Jiri Pirko 2021-05-05 136
:::::: The code at line 119 was first introduced by commit
:::::: f516d881f25d5ec76a01608f6b13e88d91687f6c netdevsim: create couple of devices on each linecard
:::::: TO: Jiri Pirko <jiri@xxxxxxxxxx>
:::::: CC: Jiri Pirko <jiri@xxxxxxxxxx>
--
0-DAY CI Kernel Test Service
https://01.org/lkp