Re: [net-next PATCH v5 1/7] octeon_ep: Add driver framework and device initialization

[Bagas Sanjaya]

On 4/13/22 10:34, Veerasenareddy Burru wrote:
> @@ -0,0 +1,35 @@
> +.. SPDX-License-Identifier: GPL-2.0+
> +
> +====================================================================
> +Linux kernel networking driver for Marvell's Octeon PCI Endpoint NIC
> +====================================================================
> +
> +Network driver for Marvell's Octeon PCI EndPoint NIC.
> +Copyright (c) 2020 Marvell International Ltd.
> +
> +Contents
> +========
> +
> +- `Overview`_
> +- `Supported Devices`_
> +- `Interface Control`_
> +

Why did you manually add table of contents?

> +Interface Control
> +=================
> +Network Interface control like changing mtu, link speed, link down/up are
> +done by writing command to mailbox command queue, a mailbox interface
> +implemented through a reserved region in BAR4.
> +This driver writes the commands into the mailbox and the firmware on the
> +Octeon device processes them. The firmware also sends unsolicited notifications
> +to driver for events suchs as link change, through notification queue
> +implemented as part of mailbox interface.

How does one write to mailbox command queue?

-- 
An old man doll... just what I always wanted! - Clara