Re: [PATCH v5 10/10] ARM: dts: msm: Add tpdm mm/prng for sm8250

[Konrad Dybcio]

On 12/04/2022 14:50, Mao Jinlong wrote:
> Add tpdm mm and tpdm prng for sm8250.
>
> +---------------+                +-------------+
> |  tpdm@6c08000 |                |tpdm@684C000 |
> +-------|-------+                +------|------+
>          |                               |
> +-------|-------+                       |
> | funnel@6c0b000|                       |
> +-------|-------+                       |
>          |                               |
> +-------|-------+                       |
> |funnel@6c2d000 |                       |
> +-------|-------+                       |
>          |                               |
>          |    +---------------+          |
>          +----- tpda@6004000  -----------+
>               +-------|-------+
>                       |
>               +-------|-------+
>               |funnel@6005000 |
>               +---------------+
>
> Signed-off-by: Mao Jinlong <quic_jinlmao@xxxxxxxxxxx>
> ---
>   .../arm64/boot/dts/qcom/sm8250-coresight.dtsi | 182 ++++++++++++++++++
>   1 file changed, 182 insertions(+)

Same comments as in 9/10: title, sorting, status=disabled, line breaks..


Also, please make sure to use lowercase hex throughout the file (i.e. 
0x684c000 not 0x684C000).


Konrad


> diff --git a/arch/arm64/boot/dts/qcom/sm8250-coresight.dtsi b/arch/arm64/boot/dts/qcom/sm8250-coresight.dtsi
> index 1de42fd39248..9c710b69a804 100644
> --- a/arch/arm64/boot/dts/qcom/sm8250-coresight.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8250-coresight.dtsi
> @@ -44,6 +44,14 @@
>   			#address-cells = <1>;
>   			#size-cells = <0>;
>   
> +			port@6 {
> +				reg = <6>;
> +				funnel_in0_in_funnel_qatb: endpoint {
> +					remote-endpoint =
> +						<&funnel_qatb_out_funnel_in0>;
> +				};
> +			};
> +
>   			port@7 {
>   				reg = <7>;
>   				funnel0_in7: endpoint {
> @@ -523,4 +531,178 @@
>   			};
>   		};
>   	};
> +
> +	tpdm@6c08000 {
> +		compatible = "arm,primecell";
> +		reg = <0 0x6c08000 0 0x1000>;
> +		reg-names = "tpdm-base";
> +
> +		clocks = <&aoss_qmp>;
> +		clock-names = "apb_pclk";
> +
> +		out-ports {
> +			port {
> +				tpdm_mm_out_funnel_dl_mm: endpoint {
> +					remote-endpoint =
> +						<&funnel_dl_mm_in_tpdm_mm>;
> +				};
> +			};
> +		};
> +	};
> +
> +	funnel@6c0b000 {
> +		compatible = "arm,coresight-dynamic-funnel", "arm,primecell";
> +
> +		reg = <0 0x6c0b000 0 0x1000>;
> +		reg-names = "funnel-base";
> +
> +		clocks = <&aoss_qmp>;
> +		clock-names = "apb_pclk";
> +
> +		out-ports {
> +			port {
> +				funnel_dl_mm_out_funnel_dl_center: endpoint {
> +					remote-endpoint =
> +					  <&funnel_dl_center_in_funnel_dl_mm>;
> +				};
> +			};
> +		};
> +
> +		in-ports {
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +
> +			port@3 {
> +				reg = <3>;
> +				funnel_dl_mm_in_tpdm_mm: endpoint {
> +					remote-endpoint =
> +					    <&tpdm_mm_out_funnel_dl_mm>;
> +				};
> +			};
> +		};
> +	};
> +
> +	funnel@6c2d000 {
> +		compatible = "arm,coresight-dynamic-funnel", "arm,primecell";
> +
> +		reg = <0 0x6c2d000 0 0x1000>;
> +		reg-names = "funnel-base";
> +
> +		clocks = <&aoss_qmp>;
> +		clock-names = "apb_pclk";
> +
> +		out-ports {
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +			port {
> +				tpdm_mm_out_tpda9: endpoint {
> +					remote-endpoint =
> +					    <&tpda_9_in_tpdm_mm>;
> +				};
> +			};
> +		};
> +
> +		in-ports {
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +
> +			port@2 {
> +				reg = <2>;
> +				funnel_dl_center_in_funnel_dl_mm: endpoint {
> +					remote-endpoint =
> +					<&funnel_dl_mm_out_funnel_dl_center>;
> +				};
> +			};
> +		};
> +	};
> +
> +	tpdm@684C000 {
> +		compatible = "arm,primecell";
> +		reg = <0 0x684C000 0 0x1000>;
> +		reg-names = "tpdm-base";
> +
> +		clocks = <&aoss_qmp>;
> +		clock-names = "apb_pclk";
> +
> +		out-ports {
> +			port {
> +				tpdm_prng_out_tpda_23: endpoint {
> +					remote-endpoint =
> +						<&tpda_23_in_tpdm_prng>;
> +				};
> +			};
> +		};
> +	};
> +
> +	tpda@6004000 {
> +		compatible = "arm,primecell";
> +		reg = <0 0x6004000 0 0x1000>;
> +		reg-names = "tpda-base";
> +
> +		clocks = <&aoss_qmp>;
> +		clock-names = "apb_pclk";
> +
> +		out-ports {
> +			port {
> +				reg = <0>;
> +				tpda_out_funnel_qatb: endpoint {
> +					remote-endpoint =
> +						<&funnel_qatb_in_tpda>;
> +				};
> +			};
> +		};
> +
> +		in-ports {
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +
> +			port@9 {
> +				reg = <9>;
> +				tpda_9_in_tpdm_mm: endpoint {
> +					remote-endpoint =
> +						<&tpdm_mm_out_tpda9>;
> +				};
> +			};
> +
> +			port@23 {
> +				reg = <23>;
> +				tpda_23_in_tpdm_prng: endpoint {
> +					remote-endpoint =
> +						<&tpdm_prng_out_tpda_23>;
> +				};
> +			};
> +		};
> +	};
> +
> +	funnel@6005000 {
> +		compatible = "arm,primecell";
> +
> +		reg = <0 0x6005000 0 0x1000>;
> +		reg-names = "funnel-base";
> +
> +		clocks = <&aoss_qmp>;
> +		clock-names = "apb_pclk";
> +
> +		out-ports {
> +			port {
> +				funnel_qatb_out_funnel_in0: endpoint {
> +					remote-endpoint =
> +						<&funnel_in0_in_funnel_qatb>;
> +				};
> +			};
> +		};
> +
> +		in-ports {
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +
> +			port@0 {
> +				reg = <0>;
> +				funnel_qatb_in_tpda: endpoint {
> +					remote-endpoint =
> +						<&tpda_out_funnel_qatb>;
> +				};
> +			};
> +		};
> +	};
>   };