Re: [PATCH 1/6] PCI: rcar-gen2: Add support for clocks
From: Herve Codina
Date: Wed Apr 13 2022 - 10:56:01 EST
Hi Rob,
On Tue, 12 Apr 2022 10:50:10 -0500
Rob Herring <robh@xxxxxxxxxx> wrote:
> On Tue, Apr 12, 2022 at 11:40:24AM +0200, Herve Codina wrote:
> > The PCI rcar-gen2 does not call any clk_prepare_enable().
> > This lead to an access failure when the driver tries to access
> > the IP (at least on a RZ/N1D platform).
> >
> > Prepare and enable clocks using the bulk version of
> > clk_prepare_enable() in order to prepare and enable all clocks
> > attached to this device.
>
> The binding says there is only a single clock, so it needs an update if
> there are multiple clocks. (And ideally converted to DT schema format.)
Indeed, I will convert to DT schema format and update the clocks property
description.
Regards,
Hervé