Re: [PATCH 09/14] mips: dts: ralink: mt7621: use the new compatible string for MT7621 pinctrl

[Krzysztof Kozlowski]

On 13/04/2022 08:07, Arınç ÜNAL wrote:
> Use the new compatible string "ralink,mt7621-pinctrl" for the Ralink MT7621
> pinctrl subdriver on mt7621.dtsi.
> 
> Signed-off-by: Arınç ÜNAL <arinc.unal@xxxxxxxxxx>
> ---
>  arch/mips/boot/dts/ralink/mt7621.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/mips/boot/dts/ralink/mt7621.dtsi b/arch/mips/boot/dts/ralink/mt7621.dtsi
> index 3222684915ac..ee2ec78c8952 100644
> --- a/arch/mips/boot/dts/ralink/mt7621.dtsi
> +++ b/arch/mips/boot/dts/ralink/mt7621.dtsi
> @@ -151,7 +151,7 @@ spi0: spi@b00 {
>  	};
>  
>  	pinctrl: pinctrl {
> -		compatible = "ralink,rt2880-pinmux";
> +		compatible = "ralink,mt7621-pinctrl";

The change is non-bisectable and causes issues all other users of DT
(other projects, systems etc). This is discouraged in general, so you
should describe it. The commit msg lacks answer to the main question:
Why? You focused only on what you are doing, but why you are doing is
actually more important for such change.

Best regards,
Krzysztof