Re: [PATCH] staging: Remove the drivers for the Unisys s-Par

From: Alison Schofield
Date: Wed Apr 13 2022 - 11:36:34 EST


On Wed, Apr 13, 2022 at 09:35:53AM +0200, Fabio M. De Francesco wrote:
> On mercoled? 13 aprile 2022 08:52:47 CEST Greg Kroah-Hartman wrote:
> > On Tue, Apr 12, 2022 at 11:59:01PM +0200, Fabio M. De Francesco wrote:
> > > The Unisys sub-tree contains three drivers for the "Unisys Secure
> Partition"
> > > (s-Par(R)): visorhba, visorinput, visornic.
> > >
> > > They have no maintainers, in fact the only one that is listed in
> MAINTAINERS
> > > has an unreacheable email address. During 2021 and 2022 several patches
> have
> > > been submitted to these drivers but nobody at Unisys cared of reviewing
> the
> > > changes. Probably, also the "sparmaintainer" internal list of
> unisys.com is
> > > not anymore read by interested Unisys' engineers.
> > >
> > > Therefore, remove the ./unisys subdirectory of staging and delete the
> related
> > > entries in the MAINTAINERS, Kconfig, Makefile files.
> > >
> > > Suggested-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> > > Signed-off-by: Fabio M. De Francesco <fmdefrancesco@xxxxxxxxx>
> > > ---
> > > MAINTAINERS | 8 -
> >
> > You forgot to at least cc: the people/list on the MAINTAINERS entry that
> > you are removing here, to give them a hint that this is happening in
> > case they want to speak up here (and to give us the ability to point to
> > that years later when they complain they were never notified...)
>
> Yes, this is a good idea. I'll submit a v2 and add two "Cc:" lines, one to
> David Kershner and the other to the "sparmaintainer" list at unisys.com.

There is another contact in the TODO file (last updated 2015 though ;))
Ken Cox <jkc@xxxxxxxxxx>

>
> > Also, if you are in the "delete code" mood, I think drivers/staging/vme/
> > and drivers/vme/ can probably also be deleted given that the maintainer
> > for that has moved on to other jobs. Ask them and see!
>
> I can and will do exactly as you just suggested, but only after April 22nd
> (unless others want to do these tasks sooner, and in that case they are
> welcome :)).
>
> Thanks,
>
> Fabio M. De Francesco
>
>
>