Re: [PATCH] crypto: ccp - Fix the INIT_EX data file open failure

[Peter Gonda]

On Mon, Apr 11, 2022 at 12:00 PM Jacky Li <jackyli@xxxxxxxxxx> wrote:
>
> There are 2 common cases when INIT_EX data file might not be
> opened successfully and fail the sev initialization:
>
> 1. In user namespaces, normal user tasks (e.g. VMM) can change their
>    current->fs->root to point to arbitrary directories. While
>    init_ex_path is provided as a module param related to root file
>    system. Solution: use the root directory of init_task to avoid
>    accessing the wrong file.
>
> 2. Normal user tasks (e.g. VMM) don't have the privilege to access
>    the INIT_EX data file. Solution: open the file as root and
>    restore permissions immediately.
>
> Signed-off-by: Jacky Li <jackyli@xxxxxxxxxx>

Reviewed-by: Peter Gonda <pgonda@xxxxxxxxxx>

Agreed about the fixes tag.