Re: [PATCH] dt-bindings: thermal: uniphier: Use unevaluatedProperties and common bindings

From: Rob Herring
Date: Wed Apr 13 2022 - 14:56:11 EST


On Thu, Apr 07, 2022 at 04:45:33PM +0900, Kunihiko Hayashi wrote:
> This adds common bindings thermal-sensor.yaml and this is preferred for
> unevaluatedProperties instead of additionalProperties.
>
> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@xxxxxxxxxxxxx>
> ---
> .../bindings/thermal/socionext,uniphier-thermal.yaml | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/thermal/socionext,uniphier-thermal.yaml b/Documentation/devicetree/bindings/thermal/socionext,uniphier-thermal.yaml
> index c5b25ce44956..537c93da1397 100644
> --- a/Documentation/devicetree/bindings/thermal/socionext,uniphier-thermal.yaml
> +++ b/Documentation/devicetree/bindings/thermal/socionext,uniphier-thermal.yaml
> @@ -14,6 +14,9 @@ description: |
> maintainers:
> - Kunihiko Hayashi <hayashi.kunihiko@xxxxxxxxxxxxx>
>
> +allOf:
> + - $ref: "thermal-sensor.yaml#"

No advantage to adding this as this schema still has to define the value
for "#thermal-sensor-cells".

> +
> properties:
> compatible:
> enum:
> @@ -40,7 +43,7 @@ required:
> - interrupts
> - "#thermal-sensor-cells"
>
> -additionalProperties: false
> +unevaluatedProperties: false
>
> examples:
> - |
> --
> 2.25.1
>
>