Re: [PATCH v2 1/2] dt-bindings: devfreq: mediatek: Add mtk cci devfreq dt-bindings

From: Chanwoo Choi
Date: Wed Apr 13 2022 - 16:54:46 EST


On 22. 4. 12. 18:17, Krzysztof Kozlowski wrote:
On 11/04/2022 14:10, Johnson Wang wrote:
Also please put it in the "interconnect" directory.


I don't really know about "interconnect".
However, it looks like a Linux framework about data transfer and "NoC".

While this cci driver is more like a power managment which is
responsible for adjusting voltages and frequencies.
In my opinion, "devfreq" should be more suitable.

Please correct me if my understanding is wrong.

devfreq is a Linux mechanism, not a real device/hardware. We try to put
the bindings in directories/subsystems matching the hardware, therefore
devfreq is not appropriate.

Whether interconnect - or other subsystem - is appropriate, I am not
sure. To me this looks exactly like bus bandwidth management and you
even use "interconnect" in several places. So interconnect matches.

I think that 'Documentation/devicetree/bindings/arm/mediatek' is proper.

--
Best Regards,
Samsung Electronics
Chanwoo Choi