Re: [PATCH v4 03/11] riscv: use fallback for random_get_entropy() instead of zero

From: Jason A. Donenfeld
Date: Wed Apr 13 2022 - 18:40:44 EST


Hi Rob,

On Wed, Apr 13, 2022 at 4:40 PM Rob Herring <robh@xxxxxxxxxx> wrote:
> Moving this check to get_cycles() implementation would eliminate the
> RiscV implementation of random_get_entropy() if you follow my other
> suggestion.

Not an option. random_get_entropy() != get_cycles(). Sometimes these
are different functions. Returning random_get_entropy_fallback() from
get_cycles(), for example, wouldn't make any sense.

Jason