Re: [PATCH 09/18] objtool: Add stack validation cmdline option

From: Peter Zijlstra
Date: Thu Apr 14 2022 - 04:43:40 EST


On Wed, Apr 13, 2022 at 04:19:44PM -0700, Josh Poimboeuf wrote:
> + if (opts.stackval || opts.orc || opts.uaccess) {
> + ret = validate_functions(file);
> + if (ret < 0)
> + goto out;
> + warnings += ret;
>
> + ret = validate_unwind_hints(file, NULL);
> if (ret < 0)
> goto out;
> warnings += ret;
> +
> + if (!warnings) {
> + ret = validate_reachable_instructions(file);
> + if (ret < 0)
> + goto out;
> + warnings += ret;
> + }
> }

Doesn't SLS also depend on validate_functions() ?