Re: [PATCH] scripts: dummy-tools, add pahole

[Jiri Slaby]

On 14. 04. 22, 11:42, Jiri Slaby wrote:
> On 14. 04. 22, 11:33, Masahiro Yamada wrote:
> > On Thu, Apr 14, 2022 at 6:14 PM Jiri Slaby <jslaby@xxxxxxx> wrote:
> > > CONFIG_PAHOLE_VERSION is a part of a config since the commit below. And
> > > when multiple people update the config, this value constantly changes.
> > > Even if they use dummy scripts.
> > >
> > > To fix this:
> > > * add a pahole dummy script returning v99.99 -> 9999
> > > * call it in Makefile taking CROSS_COMPILE into account.
> > >
> > > The latter happens only if $(CROSS_COMPILE)pahole really exists. This is
> > > because a cross pahole likely exists only in dummy tools now, not in
> > > real cross tools.
> >
> >
> > I do not think this is the right thing to do.
> >
> > (As I said somewhere, I am opposed to checking pahole version in 
> > Kconfig).
>
> If you ask me, I am all for removal as this causes pain. But it's there, 
> so I cannot do anything about that.
>
> > Also, $(CROSS_COMPILE)pahole looks insane.
> >
> > You can create a dummy pahole in your local system.
> >
> > $ echo 'echo v99.99' > $HOME/bin/dummy-pahole
> > $ chmod +x  $HOME/bin/dummy-pahole
> > $ make CROSS_COMPILE=scripts/dummy-tools  PAHOLE=dummy-pahole  menuconfig
>
> Well, the question is how do I that for every kernel developer in SUSE?

IOW it'd be quite easier if the scripts/dummy-tools/pahole part of the 
patch was in the tree. (I don't insist on the Makefile change.)

> thanks,-- 
js
suse labs