Re: [PATCH V2 3/3] serial: stm32: add earlycon support

[Geert Uytterhoeven]

Hi Valentin,

On Thu, Apr 14, 2022 at 2:17 PM Valentin CARON
<valentin.caron@xxxxxxxxxxx> wrote:
> On 4/11/22 16:59, Geert Uytterhoeven wrote:
> > On Fri, Apr 8, 2022 at 3:14 PM Valentin Caron
> > <valentin.caron@xxxxxxxxxxx> wrote:
> >> Add early console support in stm32 uart driver.
> >>
> >> Signed-off-by: Alexandre Torgue <alexandre.torgue@xxxxxxxxxxx>
> >> Signed-off-by: Valentin Caron <valentin.caron@xxxxxxxxxxx>
> > Thanks for your patch!
> >
> >> --- a/Documentation/admin-guide/kernel-parameters.txt
> >> +++ b/Documentation/admin-guide/kernel-parameters.txt
> >> @@ -1264,6 +1264,12 @@
> >>                          address must be provided, and the serial port must
> >>                          already be setup and configured.
> >>
> >> +               stm32,<addr>
> >> +                       Use early console provided by ST Microelectronics
> >> +                       serial driver for STM32 SoCs. A valid base address
> >> +                       must be provided, and the serial port must already
> >> +                       be setup and configured.
> > Why do you need this parameter?
> >
> > Given this driver uses DT, can't it figure out the serial port address
> > from chosen/stdout-path?
>
> I took the example of other serial drivers.
> Both methods work (with earlycon/stdout-path and with
> earlycon=stm32,0xXXXXXXX)
> but your right, the second will probably never used on this driver.
>
> Should I remove it ?

I think you should.  The less platform-specific kernel parameters,
the better. And the less bad examples to copy from.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds