[axboe-block:sock-nolock.2 5/5] net/mptcp/subflow.c:1796:20: error: too few arguments to function call, expected 2, have 1
From: kernel test robot
Date: Thu Apr 14 2022 - 10:20:33 EST
tree: https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git sock-nolock.2
head: 95f2e3bd27b30244f79deacbc1aac49d294bd854
commit: 95f2e3bd27b30244f79deacbc1aac49d294bd854 [5/5] net: allow sk_prot->release_cb() without sock lock held
config: hexagon-randconfig-r041-20220414 (https://download.01.org/0day-ci/archive/20220414/202204142114.rOCzHB7d-lkp@xxxxxxxxx/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 6b7e6ea489f6dd45a9b0da9ac20871560917b9b0)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git/commit/?id=95f2e3bd27b30244f79deacbc1aac49d294bd854
git remote add axboe-block https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git
git fetch --no-tags axboe-block sock-nolock.2
git checkout 95f2e3bd27b30244f79deacbc1aac49d294bd854
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash net/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>
All errors (new ones prefixed by >>):
>> net/mptcp/subflow.c:1796:20: error: too few arguments to function call, expected 2, have 1
tcp_release_cb(ssk);
~~~~~~~~~~~~~~ ^
include/net/tcp.h:337:6: note: 'tcp_release_cb' declared here
void tcp_release_cb(struct sock *sk, bool locked);
^
>> net/mptcp/subflow.c:1841:31: error: incompatible function pointer types assigning to 'void (*)(struct sock *, bool)' (aka 'void (*)(struct sock *, _Bool)') from 'void (struct sock *)' [-Werror,-Wincompatible-function-pointer-types]
tcp_prot_override.release_cb = tcp_release_cb_override;
^ ~~~~~~~~~~~~~~~~~~~~~~~
2 errors generated.
vim +1796 net/mptcp/subflow.c
cec37a6e41aae7 Peter Krystad 2020-01-21 1788
b19bc2945b40b9 Paolo Abeni 2021-01-20 1789 static void tcp_release_cb_override(struct sock *ssk)
b19bc2945b40b9 Paolo Abeni 2021-01-20 1790 {
b19bc2945b40b9 Paolo Abeni 2021-01-20 1791 struct mptcp_subflow_context *subflow = mptcp_subflow_ctx(ssk);
b19bc2945b40b9 Paolo Abeni 2021-01-20 1792
b19bc2945b40b9 Paolo Abeni 2021-01-20 1793 if (mptcp_subflow_has_delegated_action(subflow))
b19bc2945b40b9 Paolo Abeni 2021-01-20 1794 mptcp_subflow_process_delegated(ssk);
b19bc2945b40b9 Paolo Abeni 2021-01-20 1795
b19bc2945b40b9 Paolo Abeni 2021-01-20 @1796 tcp_release_cb(ssk);
b19bc2945b40b9 Paolo Abeni 2021-01-20 1797 }
b19bc2945b40b9 Paolo Abeni 2021-01-20 1798
2303f994b3e187 Peter Krystad 2020-01-21 1799 static struct tcp_ulp_ops subflow_ulp_ops __read_mostly = {
2303f994b3e187 Peter Krystad 2020-01-21 1800 .name = "mptcp",
2303f994b3e187 Peter Krystad 2020-01-21 1801 .owner = THIS_MODULE,
2303f994b3e187 Peter Krystad 2020-01-21 1802 .init = subflow_ulp_init,
2303f994b3e187 Peter Krystad 2020-01-21 1803 .release = subflow_ulp_release,
cec37a6e41aae7 Peter Krystad 2020-01-21 1804 .clone = subflow_ulp_clone,
2303f994b3e187 Peter Krystad 2020-01-21 1805 };
2303f994b3e187 Peter Krystad 2020-01-21 1806
cec37a6e41aae7 Peter Krystad 2020-01-21 1807 static int subflow_ops_init(struct request_sock_ops *subflow_ops)
cec37a6e41aae7 Peter Krystad 2020-01-21 1808 {
cec37a6e41aae7 Peter Krystad 2020-01-21 1809 subflow_ops->obj_size = sizeof(struct mptcp_subflow_request_sock);
cec37a6e41aae7 Peter Krystad 2020-01-21 1810 subflow_ops->slab_name = "request_sock_subflow";
cec37a6e41aae7 Peter Krystad 2020-01-21 1811
cec37a6e41aae7 Peter Krystad 2020-01-21 1812 subflow_ops->slab = kmem_cache_create(subflow_ops->slab_name,
cec37a6e41aae7 Peter Krystad 2020-01-21 1813 subflow_ops->obj_size, 0,
cec37a6e41aae7 Peter Krystad 2020-01-21 1814 SLAB_ACCOUNT |
cec37a6e41aae7 Peter Krystad 2020-01-21 1815 SLAB_TYPESAFE_BY_RCU,
cec37a6e41aae7 Peter Krystad 2020-01-21 1816 NULL);
cec37a6e41aae7 Peter Krystad 2020-01-21 1817 if (!subflow_ops->slab)
cec37a6e41aae7 Peter Krystad 2020-01-21 1818 return -ENOMEM;
cec37a6e41aae7 Peter Krystad 2020-01-21 1819
79c0949e9a09f6 Peter Krystad 2020-01-21 1820 subflow_ops->destructor = subflow_req_destructor;
79c0949e9a09f6 Peter Krystad 2020-01-21 1821
cec37a6e41aae7 Peter Krystad 2020-01-21 1822 return 0;
cec37a6e41aae7 Peter Krystad 2020-01-21 1823 }
cec37a6e41aae7 Peter Krystad 2020-01-21 1824
d39dceca388ad0 Paolo Abeni 2020-06-26 1825 void __init mptcp_subflow_init(void)
2303f994b3e187 Peter Krystad 2020-01-21 1826 {
08b8d080982fec Florian Westphal 2020-07-30 1827 mptcp_subflow_request_sock_ops = tcp_request_sock_ops;
08b8d080982fec Florian Westphal 2020-07-30 1828 if (subflow_ops_init(&mptcp_subflow_request_sock_ops) != 0)
cec37a6e41aae7 Peter Krystad 2020-01-21 1829 panic("MPTCP: failed to init subflow request sock ops\n");
cec37a6e41aae7 Peter Krystad 2020-01-21 1830
cec37a6e41aae7 Peter Krystad 2020-01-21 1831 subflow_request_sock_ipv4_ops = tcp_request_sock_ipv4_ops;
7ea851d19b2359 Florian Westphal 2020-11-30 1832 subflow_request_sock_ipv4_ops.route_req = subflow_v4_route_req;
cec37a6e41aae7 Peter Krystad 2020-01-21 1833
cec37a6e41aae7 Peter Krystad 2020-01-21 1834 subflow_specific = ipv4_specific;
cec37a6e41aae7 Peter Krystad 2020-01-21 1835 subflow_specific.conn_request = subflow_v4_conn_request;
cec37a6e41aae7 Peter Krystad 2020-01-21 1836 subflow_specific.syn_recv_sock = subflow_syn_recv_sock;
cec37a6e41aae7 Peter Krystad 2020-01-21 1837 subflow_specific.sk_rx_dst_set = subflow_finish_connect;
4cf86ae84c7183 Paolo Abeni 2022-03-07 1838 subflow_specific.rebuild_header = subflow_rebuild_header;
cec37a6e41aae7 Peter Krystad 2020-01-21 1839
b19bc2945b40b9 Paolo Abeni 2021-01-20 1840 tcp_prot_override = tcp_prot;
b19bc2945b40b9 Paolo Abeni 2021-01-20 @1841 tcp_prot_override.release_cb = tcp_release_cb_override;
b19bc2945b40b9 Paolo Abeni 2021-01-20 1842
:::::: The code at line 1796 was first introduced by commit
:::::: b19bc2945b40b9fd38e835700907ffe8534ef0de mptcp: implement delegated actions
:::::: TO: Paolo Abeni <pabeni@xxxxxxxxxx>
:::::: CC: Jakub Kicinski <kuba@xxxxxxxxxx>
--
0-DAY CI Kernel Test Service
https://01.org/lkp