Re: [PATCH] iio: gp2ap020a00f: Fix signedness bug

From: Andy Shevchenko
Date: Thu Apr 14 2022 - 11:31:51 EST


On Thu, Apr 14, 2022 at 2:19 PM Haowen Bai <baihaowen@xxxxxxxxx> wrote:
>
> function gp2ap020a00f_get_thresh_reg() is unsigned but returning -EINVAL
> errcode, and thresh_reg_l is unsigned but receiving -EINVAL errcode. so
> we have to change u8 -> s8.

s8 is not enough to hold an (arbitrary) error code. To be on the safe
side you need to use int.

--
With Best Regards,
Andy Shevchenko