Re: [PATCH 0/6] phy: rockchip-inno-usb2: RK356x OTG fix and enhancements

From: Michael Riesch
Date: Thu Apr 14 2022 - 11:31:59 EST


Hello Samuel,

On 4/14/22 05:22, Samuel Holland wrote:
> This series gets USB OTG working on the RK356x SoCs, as used in the
> PineNote tablet.
>
> - Patch 1 fixes an interrupt storm issue specific to RK356x.
> - Patches 2 and 3 are a couple of small optimizations.
> - Patches 4 and 5 reduce the delay when unplugging from the OTG port.
> - Patch 6 allows OTG ports to work in host mode without depending on
> another driver to provide an extcon. The specific use case here is
> a Type-C port controller that provides a hardware "ID pin" output.
>
>
> Samuel Holland (6):
> phy: rockchip-inno-usb2: Fix muxed interrupt support
> phy: rockchip-inno-usb2: Do not check bvalid twice
> phy: rockchip-inno-usb2: Do not lock in bvalid IRQ handler
> phy: rockchip-inno-usb2: Support multi-bit mask properties
> phy: rockchip-inno-usb2: Handle bvalid falling
> phy: rockchip-inno-usb2: Handle ID IRQ
>
> drivers/phy/rockchip/phy-rockchip-inno-usb2.c | 125 +++++++++++++++---
> 1 file changed, 105 insertions(+), 20 deletions(-)

Thanks a lot! This series fixes the USB gadget operation of my RK356x
boards.

With suitable DTS changes, the zero gadget module, and usbtest

Tested-by: Michael Riesch <michael.riesch@xxxxxxxxxxxxxx>

on a RK3568 EVB1 and a Rock 3 Model A.

Best regards,
Michael