Re: [PATCH V4 18/31] x86/sgx: Support modifying SGX page type

[Reinette Chatre]

Hi Jarkko,

On 4/14/2022 4:11 AM, Jarkko Sakkinen wrote:
> On Wed, 2022-04-13 at 14:10 -0700, Reinette Chatre wrote:
>> @@ -97,6 +99,23 @@ struct sgx_enclave_restrict_permissions {
>>         __u64 count;
>>  };
>>  
>> +/**
>> + * struct sgx_enclave_modify_type - parameters for %SGX_IOC_ENCLAVE_MODIFY_TYPES
>> + * @offset:    starting page offset (page aligned relative to enclave base
>> + *             address defined in SECS)
>> + * @length:    length of memory (multiple of the page size)
>> + * @page_type: new type for pages in range described by @offset and @length
>> + * @result:    (output) SGX result code of ENCLS[EMODT] function
>> + * @count:     (output) bytes successfully changed (multiple of page size)
>> + */
>> +struct sgx_enclave_modify_type {
> 
> This should match the ioctl name i.e. "types".

Will do (and also the function names).

...

> 
> Other than that LGTM

Thank you

Reinette