Re: [PATCH 03/14] perf vendor events intel: Add sapphirerapids events

[Liang, Kan]

On 4/14/2022 12:36 PM, Ian Rogers wrote:
> On Thu, Apr 14, 2022 at 8:03 AM Liang, Kan <kan.liang@xxxxxxxxxxxxxxx> wrote:
> > On 4/13/2022 5:04 PM, Ian Rogers wrote:
> > > Events were generated from 01.org using:
> > > https://github.com/intel/event-converter-for-linux-perf
> > >
> > > Signed-off-by: Ian Rogers<irogers@xxxxxxxxxx>
> > > ---
> > >    tools/perf/pmu-events/arch/x86/mapfile.csv    |    1 +
> > >    .../arch/x86/sapphirerapids/cache.json        | 1083 ++++++++++++++
> > >    .../x86/sapphirerapids/floating-point.json    |  218 +++
> > >    .../arch/x86/sapphirerapids/frontend.json     |  471 ++++++
> > >    .../arch/x86/sapphirerapids/memory.json       |  415 ++++++
> > >    .../arch/x86/sapphirerapids/other.json        |  329 +++++
> > >    .../arch/x86/sapphirerapids/pipeline.json     | 1271 +++++++++++++++++
> > >    .../x86/sapphirerapids/virtual-memory.json    |  225 +++
> >
> > Thank you very much Ian for the patches. They all looks good to me.
> >
> >       Reviewed-by: Kan Liang <kan.liang@xxxxxxxxxxxxxxx>
> >
> > BTW: I think the uncore events for SPR are also published in 01.org.
> > Do you have plan to add them later?
>
> Thanks Kan, we need to add the csv file to the github project to make
> this work. I can make a basic one if that works?

I think Zhengjun may already have one. Zhengjun?

Thanks,
Kan