Re: [PATCH 19/20] tty: n_gsm: fix wrong behavior of gsm_carrier_raised() on debug
From: Greg KH
Date: Fri Apr 15 2022 - 02:34:39 EST
On Thu, Apr 14, 2022 at 02:42:24AM -0700, D. Starke wrote:
> From: Daniel Starke <daniel.starke@xxxxxxxxxxx>
>
> gsm_carrier_raised() returns always 1 if the kernel module parameter
> 'debug' has its second least significant bit set. This changes the behavior
> of the module instead of just adding some debug output.
> Remove this 'debug' gated early out to avoid debug settings from changing
> the program flow.
>
> Fixes: e1eaea46bb40 ("tty: n_gsm line discipline")
> Cc: stable@xxxxxxxxxxxxxxx
Why is this relevant for stable backporting? It's a debugging feature
only, and you are changing how it previously worked :(