Re: [PATCH net] rxrpc: Restore removed timer deletion
From: patchwork-bot+netdevbpf
Date: Fri Apr 15 2022 - 06:00:54 EST
Hello:
This patch was applied to netdev/net.git (master)
by David S. Miller <davem@xxxxxxxxxxxxx>:
On Wed, 13 Apr 2022 11:16:25 +0100 you wrote:
> A recent patch[1] from Eric Dumazet flipped the order in which the
> keepalive timer and the keepalive worker were cancelled in order to fix a
> syzbot reported issue[2]. Unfortunately, this enables the mirror image bug
> whereby the timer races with rxrpc_exit_net(), restarting the worker after
> it has been cancelled:
>
> CPU 1 CPU 2
> =============== =====================
> if (rxnet->live)
> <INTERRUPT>
> rxnet->live = false;
> cancel_work_sync(&rxnet->peer_keepalive_work);
> rxrpc_queue_work(&rxnet->peer_keepalive_work);
> del_timer_sync(&rxnet->peer_keepalive_timer);
>
> [...]
Here is the summary with links:
- [net] rxrpc: Restore removed timer deletion
https://git.kernel.org/netdev/net/c/ee3b0826b476
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html