Re: [RFC PATCH 02/16] dt-bindings: display: rockchip: Add EBC binding
From: Andreas Kemnade
Date: Fri Apr 15 2022 - 07:46:41 EST
On Thu, 14 Apr 2022 22:00:09 -0500
Samuel Holland <samuel@xxxxxxxxxxxx> wrote:
> Hi Andreas,
>
> Thanks for the comments.
>
> On 4/14/22 3:15 AM, Andreas Kemnade wrote:
> > Hi Samuel,
> >
> > for comparison, here is my submission for the IMX EPDC bindings:
> >
> > https://lore.kernel.org/linux-devicetree/20220206080016.796556-2-andreas@xxxxxxxxxxxx/
> >
> > On Wed, 13 Apr 2022 17:19:02 -0500
> > Samuel Holland <samuel@xxxxxxxxxxxx> wrote:
> >
> > [...]
> > we have sy7636a driver in kernel which should be suitable for powering a EPD
> > and temperature measurement. So I would expect that to be
> >> + io-channels:
> >> + maxItems: 1
> >> + description: I/O channel for panel temperature measurement
> >> +
> > so how would I reference the hwmon/thermal(-zone) of the sy7636a here?
>
> It seems the consensus is to use a thermal zone for panel temperature, so I will
> need to change this.
>
I am open to anything here as long as it fits together.
> I think it's best to reference the thermal zone by phandle, not by name, even if
> it requires extending the thermal zone API to support this.
>
maybe referencing the hwmon might be interesting, or we add a hwmon_iio
adaptor. The other way round it is there. The thermal zone stuff is
only needed because hwmon cannot referenced directly.
Regards,
Andreas