Re: [PATCH 2/2] dt-bindings: clock: ehrpwm: Add AM62 specific compatible

From: Nishanth Menon
Date: Fri Apr 15 2022 - 13:40:30 EST


On 16:41-20220415, Georgi Vlaev wrote:
> Introduce AM62 specific compatible for EPWM time-base
> sub-module clock. The time-base clock setup is identical
> to AM64. The only difference is AM62 provides 3 time-base
> clocks instead of the 9 found in AM64.
>
> Signed-off-by: Georgi Vlaev <g-vlaev@xxxxxx>
> Tested-by: Vignesh Raghavendra <vigneshr@xxxxxx>

Reviewed-by: Nishanth Menon <nm@xxxxxx>


That said, please re-org the patches. Bindings come before the driver
changes :)

> ---
> .../devicetree/bindings/clock/ti,am654-ehrpwm-tbclk.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/clock/ti,am654-ehrpwm-tbclk.yaml b/Documentation/devicetree/bindings/clock/ti,am654-ehrpwm-tbclk.yaml
> index 9b537bc876b5..66765116aff5 100644
> --- a/Documentation/devicetree/bindings/clock/ti,am654-ehrpwm-tbclk.yaml
> +++ b/Documentation/devicetree/bindings/clock/ti,am654-ehrpwm-tbclk.yaml
> @@ -15,6 +15,7 @@ properties:
> - enum:
> - ti,am654-ehrpwm-tbclk
> - ti,am64-epwm-tbclk
> + - ti,am62-epwm-tbclk
> - const: syscon
>
> "#clock-cells":
> --
> 2.30.2
>

--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D