Re: [PATCH] ARM: mmu: fix access to illegal address when using earlycon & memblock=debug

From: Linus Walleij
Date: Sun Apr 17 2022 - 19:21:29 EST


On Wed, Mar 16, 2022 at 3:33 AM Victor Hassan <victor@xxxxxxxxxxxxxxxxx> wrote:

> earlycon uses fixmap to create a memory map,
> So we need to close earlycon before closing fixmap,
> otherwise printk will access illegal addresses.
> After creating a new memory map, we open earlycon again.
>
> Signed-off-by: Victor Hassan <victor@xxxxxxxxxxxxxxxxx>

I think noone really noticed this because everyone on Arm systems
use CONFIG_DEBUG_LL, and that makes printascii hammer out
stuff on the console very early, it even accounts for whether we have
MMU on or not.

How are you using this on Arm even? What system and what serial
driver?

That said, it looks correct.
Acked-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Yours,
Linus Walleij