Re: [PATCH 02/23] ARM: dts: qcom-msm8974: Remove properties that are always overriden
From: Krzysztof Kozlowski
Date: Mon Apr 18 2022 - 08:57:40 EST
On 15/04/2022 13:56, Konrad Dybcio wrote:
> Model and compatible are set per-device, so having them in the SoC DTSI is
> superfluous. Remove them.
>
> Signed-off-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxx>
> ---
> arch/arm/boot/dts/qcom-msm8974.dtsi | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/qcom-msm8974.dtsi b/arch/arm/boot/dts/qcom-msm8974.dtsi
> index 412d94736c35..e216630a1d02 100644
> --- a/arch/arm/boot/dts/qcom-msm8974.dtsi
> +++ b/arch/arm/boot/dts/qcom-msm8974.dtsi
> @@ -12,8 +12,6 @@
> / {
> #address-cells = <1>;
> #size-cells = <1>;
> - model = "Qualcomm MSM8974";
> - compatible = "qcom,msm8974";
The compatible by convention is in the DTSI, even if it is not actually
used, it gives clear information what is the expected fallback.
Best regards,
Krzysztof