Re: [PATCH 1/3] media: dt-bindings: media: rockchip-vdec: Add RK3328 compatible

From: Christopher Obbard
Date: Mon Apr 25 2022 - 05:54:10 EST

On 23/04/2022 18:31, Krzysztof Kozlowski wrote:
On 23/04/2022 13:10, Krzysztof Kozlowski wrote:
On 22/04/2022 15:38, Christopher Obbard wrote:
Document the RK3328 compatible for rockchip-vdec.

Signed-off-by: Christopher Obbard <chris.obbard@xxxxxxxxxxxxx>
Documentation/devicetree/bindings/media/rockchip,vdec.yaml | 1 +
1 file changed, 1 insertion(+)

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>

I acked this but Johan pointed out that your intention was different and
missing patch context is quite important here. Please explain what
exactly you wanted in the patch? Now it looks actually wrong, so my ack
is not correct.

Wow - I think i was in weekend mode and forgot to run dtbs_check ;-).
It will be solved in v2. I have now added the check to my "pre send-patch" review checklist.

Just out of interest, I didn't get a mail from Johan and I can't seem to find it the archive either. Is that message in public as I'd like to address any other concerns at the same time ?