Re: [PATCH] batman-adv: remove unnecessary type castings

From: yuzhe
Date: Mon Apr 25 2022 - 07:14:56 EST


Hi,

thanks for your reply, we have fixed our mail server. And I'll correct and resubmit my patch.

在 2022/4/22 15:55, Sven Eckelmann 写道:

Hi,

we neither received your mail via the mailing list nor our private mail
servers. It seems your mail setup is broken:

Apr 21 15:48:37 dvalin postfix/smtpd[10256]: NOQUEUE: reject: RCPT from unknown[2400:dd01:100f:2:72e2:84ff:fe10:5f45]: 450 4.7.1 <ha.nfschina.com>: Helo command rejected: Host not found; from=<yuzhe@xxxxxxxxxxxx> to=<sven@xxxxxxxxxxxxx> proto=ESMTP helo=<ha.nfschina.co>


And when I test it myself, it is also not working:

$ dig @8.8.8.8 ha.nfschina.com

; <<>> DiG 9.16.27-Debian <<>> @8.8.8.8 ha.nfschina.com
; (1 server found)
;; global options: +cmd
;; Got answer:
;; ->>HEADER<<- opcode: QUERY, status: NXDOMAIN, id: 39639
;; flags: qr rd ra; QUERY: 1, ANSWER: 0, AUTHORITY: 1, ADDITIONAL: 1
;; OPT PSEUDOSECTION:
; EDNS: version: 0, flags:; udp: 512
;; QUESTION SECTION:
;ha.nfschina.com. IN A
;; AUTHORITY SECTION:
nfschina.com. 600 IN SOA dns11.hichina.com. hostmaster.hichina.com. 2022011002 3600 1200 86400 600

;; Query time: 328 msec
;; SERVER: 8.8.8.8#53(8.8.8.8)
;; WHEN: Fri Apr 22 09:51:56 CEST 2022
;; MSG SIZE rcvd: 105


Please fix this before sending patches out.


But the kernel test bot already demonstrated why this patch is not a good
idea. You can improve it and resent it but I will not accept it in this form.


Kind regards,
Sven