Re: [PATCH 14/14] mm, netfs, fscache: Stop read optimisation when folio removed from pagecache

From: David Howells
Date: Mon Apr 25 2022 - 08:08:20 EST

Matthew Wilcox <willy@xxxxxxxxxxxxx> wrote:

> OK. You suggested that releasepage was an acceptable place to call it.
> How about we have AS_RELEASE_ALL (... or something ...) and then
> page_has_private() becomes a bit more complicated ... to the point
> where we should probably get rid of it (by embedding it into
> filemap_release_folio():

I'm not sure page_has_private() is quite so easy to get rid of.
shrink_page_list() and collapse_file(), for example, use it to conditionalise
a call to try_to_release_page() plus some other bits.

I think that, for the moment, I would need to add a check for AS_RELEASE_ALL
to page_has_private().