Re: [PATCH] mm: use pgprot_val to get value of pgprot

[liusongtang]

OK, Shall I add "Suggested-by: Kefeng Wang <wangkefeng.wang@xxxxxxxxxx>" 
to these patches?

On 2022/4/25 18:40, Kefeng Wang wrote:
> On 2022/4/25 18:29, Anshuman Khandual wrote:
> > Should have added 'memory_hotplug' in the subject line. Otherwise
> > this does not specify where the change is (neither does the commit
> > message below).
> >
> > mm/memory_hotplug: use pgprot_val to get value of pgprot
>
>
> $ git grep "pgprot\.pgprot"
> arch/ia64/mm/init.c:    if (WARN_ON_ONCE(params->pgprot.pgprot != 
> PAGE_KERNEL.pgprot))
> arch/s390/mm/init.c:    if (WARN_ON_ONCE(params->pgprot.pgprot != 
> PAGE_KERNEL.pgprot))
> arch/sh/mm/init.c:      if (WARN_ON_ONCE(params->pgprot.pgprot != 
> PAGE_KERNEL.pgprot))
> mm/memory_hotplug.c:    if (WARN_ON_ONCE(!params->pgprot.pgprot))
>
> You can change other's codes too.
>
> > On 4/25/22 13:47, liusongtang wrote:
> > > pgprot.pgprot is a non-portable code, it should be replaced by
> > > portable macro pgprot_val.
> > >
> > > Signed-off-by: liusongtang <liusongtang@xxxxxxxxxx>
> > > ---
> > >   mm/memory_hotplug.c | 2 +-
> > >   1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
> > > index 416b38c..bf7d181 100644
> > > --- a/mm/memory_hotplug.c
> > > +++ b/mm/memory_hotplug.c
> > > @@ -303,7 +303,7 @@ int __ref __add_pages(int nid, unsigned long 
> > > pfn, unsigned long nr_pages,
> > >       int err;
> > >       struct vmem_altmap *altmap = params->altmap;
> > >   -    if (WARN_ON_ONCE(!params->pgprot.pgprot))
> > > +    if (WARN_ON_ONCE(!pgprot_val(params->pgprot)))
> > >           return -EINVAL;
> > >         VM_BUG_ON(!mhp_range_allowed(PFN_PHYS(pfn), nr_pages * 
> > > PAGE_SIZE, false));
> > Otherwise LGTM.
> >
> > Reviewed-by: Anshuman Khandual <anshuman.khandual@xxxxxxx>
> >
> > .
> .