Re: [PATCH v3 1/2] dt-bindings: mailbox: qcom-ipcc: add missing compatible for SM8450
From: Krzysztof Kozlowski
Date: Mon Apr 25 2022 - 10:11:29 EST
On 25/04/2022 16:05, David Heidelberg wrote:
> On 25/04/2022 15:51, Krzysztof Kozlowski wrote:
>> On 25/04/2022 15:47, David Heidelberg wrote:
>>> Adds forgotten compatible and update SPDX header.
>> You need to explain what is this "forgotten compatible". It's to vague.
> Forgotten by someone who implemented it in driver. Hope that clarify it
> for you and possibly other readers. Btw. qcom,*sm8450* compatibles are
> widely used and fact that `make dtbs_check` noticed it missing here
> isn't suprising..
This has to be in the commit msg, that you document compatibles already
being used. "forgotten" does not explain that.
>> The SPDX update lacks answer to "why". There is no reason to do it, so
>> please explain why it is needed.
> Please read https://spdx.org/licenses/GPL-2.0.html (red colored text).
The kernel lists it as valid SPDX and we did not deprecate it. For the
kernel it is still considered valid.
Feel free to propose otherwise but then you need to explain it in commit
msg and update LICENSES/preferred/GPL-2.0.
> I personally encountered situation, where usage GPL license without
> specific `-only` or `-or-later` caused unnecessary confusion and
Could be, I am not arguing with it. Yet kernel explicitly makes it a