Re: [PATCH v4 1/2] of: overlay: rename variables to be consistent

From: Rob Herring
Date: Mon Apr 25 2022 - 11:56:10 EST


On Wed, 20 Apr 2022 17:25:04 -0500, frowand.list@xxxxxxxxx wrote:
> From: Frank Rowand <frank.rowand@xxxxxxxx>
>
> Variables change name across function calls when there is not a good
> reason to do so. Fix by changing "fdt" to "new_fdt" and "tree" to
> "overlay_root".
>
> The name disparity was confusing when creating the following commit.
> The name changes are in this separate commit to make review of the
> following commmit less complex.
>
> Signed-off-by: Frank Rowand <frank.rowand@xxxxxxxx>
>
> ---
> Changes since v3:
> - none
>
> Changes since v2:
> - use new variable name "overlay_root" instead of new variable
> new "overlay_tree"
>
> drivers/of/overlay.c | 94 ++++++++++++++++++++++----------------------
> 1 file changed, 47 insertions(+), 47 deletions(-)
>

Applied, thanks!