Re: [PATCH 3/5] selftests: firmware: Fix the request_firmware_into_buf() test for XZ format

From: Shuah Khan
Date: Mon Apr 25 2022 - 15:45:57 EST

On 4/21/22 9:29 AM, Takashi Iwai wrote:
The test uses a different firmware name, and we forgot to adapt for
the XZ compressed file tests.

Fixes: 1798045900b7 ("selftests: firmware: Add request_firmware_into_buf tests")
Signed-off-by: Takashi Iwai <tiwai@xxxxxxx>
tools/testing/selftests/firmware/ | 2 ++
1 file changed, 2 insertions(+)

diff --git a/tools/testing/selftests/firmware/ b/tools/testing/selftests/firmware/
index 731f011def78..3ac09b401a83 100755
--- a/tools/testing/selftests/firmware/
+++ b/tools/testing/selftests/firmware/
@@ -504,6 +504,7 @@ test "$HAS_FW_LOADER_COMPRESS" != "yes" && exit 0
# test with both files present
$RUN_XZ -k $FW
config_set_name $NAME
echo "Testing with both plain and xz files present..."
@@ -529,6 +530,7 @@ done
# test with only xz file present
mv "$FW" "${FW}-orig"
+mv "$FW_INTO_BUF" "${FW_INTO_BUF}-orig"
echo "Testing with only xz file present..."
for i in $(seq 1 5); do

Thank you. Looks good to me.

Reviewed-by: Shuah Khan <skhan@xxxxxxxxxxxxxxxxxxx>

-- Shuah