Re: [PATCH v1 2/2] mmc: core: Allows to override the timeout value for ioctl() path

From: Linus Walleij
Date: Mon Apr 25 2022 - 16:15:59 EST

On Mon, Apr 25, 2022 at 10:02 PM Bean Huo <huobean@xxxxxxxxx> wrote:

> I think the current solution is the most flexible way, if the customer
> wants to override the kernel default timeout, they know how to initiate
> the correct timeout value in ioctl() based on their specific
> hardware/software system. I don't know how to convince every maintainer
> and reviewer if we don't want to give this permission or want to
> maintain a unified timeout value in the kernel driver. Given that we
> already have eMMC ioctl() support, and we've opened the door to allow
> users to specify specific cmd_timeout_ms in struct mmc_ioc_cmd{},
> please consider my change.

The patch is fine, I'm just saying we should put another patch on
top that defines a RPMB default timeout and set it to something
high, such as a minute.

Linus Walleij