Re: [PATCH] drm/msm/dpu: fix error check return value of irq_of_parse_and_map()

[Dmitry Baryshkov]

On 25/04/2022 23:10, Stephen Boyd wrote:
> Quoting cgel.zte@xxxxxxxxx (2022-04-25 02:09:47)
> > From: Lv Ruyi <lv.ruyi@xxxxxxxxxx>
> >
> > The irq_of_parse_and_map() function returns 0 on failure, and does not
> > return a negative value anyhow, so never enter this conditional branch.
> >
> > Fixes: 25fdd5933e4c ("drm/msm: Add SDM845 DPU support")
> > Reported-by: Zeal Robot <zealci@xxxxxxxxxx>
> > Signed-off-by: Lv Ruyi <lv.ruyi@xxxxxxxxxx>
> > ---
>
> Question still stands why we can't use platform device APIs.

Let's do a separate pass and replace all of functions with platform 
device API.

> Reviewed-by: Stephen Boyd <swboyd@xxxxxxxxxxxx>


--
With best wishes
Dmitry